Do not Py_DECREF args and kwargs since CPython owns them and handles it. - #95
Open
ShaheedHaque wants to merge 1 commit into
Open
ShaheedHaque wants to merge 1 commit into
ShaheedHaque wants to merge 1 commit into
Conversation
Collaborator
Author
|
@luss I am not able to get the tests running locally, but CI seems to be all green. The fix seems "safe" to me...would you like to do some sanity checks and merge or should I merge myself? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #94, as per the comments there.
Although #94 refers to Python 3.14 (and PG18), it seems this bug has always been present, and applies to Python 3.13 too (for example). Now, I have not been able to run the test suite because it fails like this:
but I can neither see the log, nor figure out how /tmp_install is supposed to work.