Skip to content

Do not Py_DECREF args and kwargs since CPython owns them and handles it. - #95

Open
ShaheedHaque wants to merge 1 commit into
pgsql-io:mainfrom
ShaheedHaque:fix_python_3_14_crash
Open

ShaheedHaque wants to merge 1 commit into
pgsql-io:mainfrom
ShaheedHaque:fix_python_3_14_crash

Conversation

@ShaheedHaque

Copy link
Copy Markdown
Collaborator

Resolves #94, as per the comments there.

Although #94 refers to Python 3.14 (and PG18), it seems this bug has always been present, and applies to Python 3.13 too (for example). Now, I have not been able to run the test suite because it fails like this:

$ PATH=$PATH:$(pg_config --bindir) make easycheck .
Python version is 3.13
echo "# +++ regress check in  +++" && PATH="/tmp_install/usr/lib/postgresql/17/bin:/main/srhaque/...:$PATH" LD_LIBRARY_PATH="/tmp_install/usr/lib/x86_64-linux-gnu" INITDB_TEMPLATE=''/tmp_install/initdb-template  /usr/lib/postgresql/17/lib/pgxs/src/makefiles/../../src/test/regress/pg_regress --temp-instance=./tmp_check --inputdir=./ --bindir=     --inputdir=test-3.13 --encoding=UTF8 --host=localhost multicorn_cache_invalidation multicorn_column_options_test multicorn_error_test multicorn_logger_test multicorn_planner_test multicorn_regression_test multicorn_sequence_test multicorn_test_date multicorn_test_dict multicorn_test_limit multicorn_test_list multicorn_test_sort write_savepoints write_test import_test write_batch_test
# +++ regress check in  +++
# initializing database system by copying initdb template
# copying of initdb template failed
# Examine "/main/srhaque/kdedev/multicorn2/log/initdb.log" for the reason.
# Command was: cp -RPp "/tmp_install/initdb-template" "/main/srhaque/.../data" > "/main/srhaque/.../log/initdb.log" 2>&1
Bail out!make: *** [Makefile:156: easycheck] Error 2

but I can neither see the log, nor figure out how /tmp_install is supposed to work.

@ShaheedHaque

Copy link
Copy Markdown
Collaborator Author

@luss I am not able to get the tests running locally, but CI seems to be all green. The fix seems "safe" to me...would you like to do some sanity checks and merge or should I merge myself?

@ShaheedHaque ShaheedHaque changed the title Do not Py_DECREF args and kwargs since Cpython owns them and handles it. Do not Py_DECREF args and kwargs since CPython owns them and handles it. Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crashing on Ubuntu 26.04 (PG18 plus Python 3.14)

1 participant