Skip to content

Support for PHP7#17

Open
dehy wants to merge 3 commits into
phansys:2.1from
zghosts:2.1
Open

Support for PHP7#17
dehy wants to merge 3 commits into
phansys:2.1from
zghosts:2.1

Conversation

@dehy

@dehy dehy commented May 13, 2016

Copy link
Copy Markdown

No description provided.

@ryanrca

ryanrca commented Dec 10, 2016

Copy link
Copy Markdown

Hi, whats the status of this 7 month old PR?
I'm building out a bunch of tools for stockmusic.net and this would be a most welcome addition to our tool chain.

Thanks!

@willwh

willwh commented Jan 18, 2017

Copy link
Copy Markdown

I'd like to know too, I'd love to use this in my project.

@w3spi5

w3spi5 commented Feb 5, 2017

Copy link
Copy Markdown

Could you merge this ? I need to use this package with php7.1

@pkwasnik

Copy link
Copy Markdown

Me too. Please support PHP7.

@phansys phansys self-requested a review May 25, 2017 20:48
@phansys

phansys commented May 26, 2017

Copy link
Copy Markdown
Owner

@dehy, thank you for your contribution; and sorry for the delay. I've merged #21 recently, so the constraints of 2.1 are now allowing PHP7.

Sincerely, I'm not depending on this library for a very long time, so I'm not keeping it maintained. Moreover, now that the official getID3 library is published at GitHub and accepts contributions, is a good time to focus all the effort on it.

For these reasons, I must abandon this fork; so, in order to provide a path to make this movement as easy as possible, I plan to create a release for 2.1.0 version and update the master branch as alias of 3.0-dev, allowing the upgrades breaking BC (like the database driver change proposed in this PR, unless you can provide a bridge capable to use the proper driver based on the capabilities of the environment).

I'll keep this PR open until these concerns are consolidated.

/cc @ryanrca, @willwh, @Rypsx, @kwach2000.

@pkwasnik

Copy link
Copy Markdown

Great, Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants