Skip to content

use default (and correct) layout - #1522

Merged
Ducasse merged 1 commit into
Pharo14from
dev-2.0
Sep 8, 2026
Merged

use default (and correct) layout#1522
Ducasse merged 1 commit into
Pharo14from
dev-2.0

Conversation

@estebanlm

Copy link
Copy Markdown
Member

@Ducasse

Ducasse commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Tx!
I read it to learn how do you address it.

S

@Ducasse
Ducasse merged commit 9e7c085 into Pharo14 Sep 8, 2026
1 of 3 checks passed
@estebanlm

estebanlm commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

in this case, the problem was the hardcoded height that was breaking the layouting.
while this should not happen (and this is arguably a bug), hardcoding values should not be used.
I also took the oportunity to "modernise" the layout (it was obviously implemented by migrating directly old spec definitions (from when they were on class side) to new style.

@Ducasse

Ducasse commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Thanks for the explanation. I reread the PR twice to try to understand and I could not find where it was hardcoded so I could not have fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants