Conversation
Adds patchElectronStageBranding helper invoked from all 4 electron build entry points after config-effective.json is written. Writes the kebab-case stage identifier into both src-electron/electron-builder.yml productName (becomes the .desktop StartupWMClass) and src-electron/package.json desktopName (Electron 41.5+ Wayland app_id) so they match per stage: dev -> phoenix-code-experimental-build stage -> phoenix-code-pre-release prod -> phoenix-code Without per-stage identifiers the AppImages collapse into one taskbar entry / icon slot when installed side-by-side. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The previous "did we change anything" check inferred regex match failure from `patched === builderYml`, which also fires when the productName line is already the target value — so a second run (or any prod build, since the committed default is already `phoenix-code`) threw "Could not find productName line". Test the regex directly instead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
src-electron/package.json desktopName and src-electron/electron-builder.yml
productName were committed as the prod kebab (`phoenix-code`), but the
matching display productName ("Phoenix Code Experimental Build") and
config.json `stage: dev` are dev defaults. Align both to the dev kebab so
a raw `npm run build:appimage` (no wrapper script) produces a coherent
dev AppImage; CI wrappers continue to overwrite per stage via
patchElectronStageBranding.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The BrowserWindow icon path resolved correctly in dev (`__dirname` = src-electron/, so `../src-tauri/icons/icon.png` reached the source tree) but not in the packaged AppImage, where `__dirname` is inside the asar and src-tauri/ is not bundled. Electron silently dropped the icon and the taskbar fell back to the generic Electron icon. Copy icon.png into the AppImage's resources/ via extraResources, and load it from process.resourcesPath when app.isPackaged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.