Conversation
…l events WorkspaceManager.EVENT_WORKSPACE_PANEL_SHOWN/HIDDEN can fire during project-open before the Git extension's init flow has registered CMD_GIT_TOGGLE_PANEL. CommandManager.get(...) then returns undefined and the .setChecked(...) call throws TypeError, which surfaced as "Exception in 'panelShown' listener" in the Git main.js stack. Wrap the lookup + setChecked in a small _setTogglePanelChecked helper that no-ops when the command isn't registered yet — init will sync the checked state on its own once it runs. Apply at the three call sites (panel-shown listener, panel-hidden listener, and toggle()).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.