Gate macOS app signing to non-PR CI runs#11
Merged
Conversation
Skip macOS signing/notarization on pull_request events so PRs produce unsigned artifacts and avoid the expensive notary upload/polling. Signing still runs on pushes to main and v* tags. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
macOS signing and notarization are expensive (notary upload plus polling) and add little value to PR validation. PR builds don't need signed assets, so paying that cost on every pull request just slows down CI.
What
In the
publishjob ofci.yml, the macOS signing steps are now gated on the run not being apull_requestevent, in addition to the existing secret-presence check.HAS_SIGNING_SECRETSenv var toMACOS_SIGNING_ENABLEDand added&& github.event_name != 'pull_request'to its expression.PRs now produce unsigned macOS
.appbundles, while pushes tomainandv*release tags continue to sign, notarize, and staple as before. This mirrors the approach already used in the EncDotNet.S100 repo.