Skip to content

pdo_cubrid/reference.xml: fix typo#3360

Merged
jordikroon merged 3 commits into
php:masterfrom
mmalferov:patch-3
May 18, 2026
Merged

pdo_cubrid/reference.xml: fix typo#3360
jordikroon merged 3 commits into
php:masterfrom
mmalferov:patch-3

Conversation

@mmalferov
Copy link
Copy Markdown
Member

No description provided.

Comment on lines +290 to 291
When you establish the connection to CUBRID, you should give username and
password except DSN.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually not sure what this note is attempting to say

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frankly, I wouldn't worry about the wording, since that extension appears to be totally unmaintained (or whatever is going on there). https://pecl.php.net/package/CUBRID has it's latest release from 2017, but "browse source" refers to the old PHP SVN server, where the latest commit was "Tagging the 9.1.0.0001 release". I have no idea where the source code is developed now; the linked homepage http://www.cubrid.org/php_api_for_cubrid is 404.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the "normal" CUBRID extension still maintained? If not we probably should remove it after the next archiving batch.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @kadishmal can clarify?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drop the docs then?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found binaries and sources on https://www.cubrid.org/downloads (click PHP and/or PDO tab). These appear to be more recent than the PECL releases (although apparently they don't offer PHP 8 versions, yet). So I conclude that the PECL package has been abandoned (for whatever reason). As such, it may make sense to clarify that on PECL, and to also remove the documentation. But that should likely be discussed on the respective mailing list.

Copy link
Copy Markdown
Member

@DanielEScherzer DanielEScherzer Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we can have that discussion separately, this is very clearly a typo that we can fix

@jordikroon
Copy link
Copy Markdown
Member

@mmalferov Could you rebase this? Once done this can be merged. As Daniel mentioned. The discussion to drop this extension completely can be done separately and should not block these type of PRs imho.

@jordikroon jordikroon merged commit e3654dc into php:master May 18, 2026
2 checks passed
@mmalferov mmalferov deleted the patch-3 branch May 18, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants