Fix fatal errors: normalise the REPL error spectrum - #7
Merged
Conversation
Route every evaluation through a single boundary (withEvaluationBoundary) that turns PHP warnings, notices and Throwables into one clean phunkie error — fixing undefined-property access, which previously leaked a raw E_WARNING and a stray null. Render uncatchable fatals (e.g. "Cannot redeclare" from loading a file twice) as a clean error via a shutdown formatter instead of a raw stack trace, and capture a loaded file's variables into the session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route every evaluation through a single boundary (withEvaluationBoundary) that turns PHP warnings, notices and Throwables into one clean phunkie error — fixing undefined-property access, which previously leaked a raw E_WARNING and a stray null.
Render uncatchable fatals (e.g. "Cannot redeclare" from loading a file twice) as a clean error via a shutdown formatter instead of a raw stack trace, and capture a loaded file's variables into the session.