Skip to content

feat: use magit-diff if magit is installed#3

Open
phye wants to merge 1 commit into
masterfrom
feature/magit_diff
Open

feat: use magit-diff if magit is installed#3
phye wants to merge 1 commit into
masterfrom
feature/magit_diff

Conversation

@phye

@phye phye commented May 26, 2026

Copy link
Copy Markdown
Owner

No description provided.

@phye phye force-pushed the feature/magit_diff branch from 37d4dff to 5259853 Compare May 26, 2026 16:30
Comment thread inline-review.el
(if (and (integerp rc) (zerop rc))
(progn
(if (fboundp 'magit-diff-range)
(magit-diff-range (concat remote-target "..." remote-source)

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not work

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magit-diff with --stat will not work

Comment thread inline-review.el
(erase-buffer)
(let ((rc (call-process "git" nil (list outbuf t) nil
"diff" "--stat"
remote-target remote-source)))

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant