Remove Perps app link from the Apps section - #509
Merged
Conversation
Contributor
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nikhilkumar1612
approved these changes
Aug 18, 2026
This was referenced Aug 18, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the Perps entry from the Apps section. The Perps app was never returned by the apps API —
AllowedAppsProviderappended it client-side (and also used it as the fallback list when the API call fails). This PR drops that local injection; the provider now shows exactly what the API returns.Per scope, no perps code is removed —
src/apps/perps/and its/perpsroute remain intact, so the app is still reachable by direct URL.Changes
src/providers/AllowedAppsProvider.tsx: stop appending the localperps-localentry on success and on API failure (failure now yields an empty list)src/providers/__tests__/AllowedAppsProvider.test.tsx: drop the perps expectationTest
vitest run src/providers/__tests__/AllowedAppsProvider.test.tsx— 2/2 passing.Note for reviewers
The home feed still renders
PerpsTile(src/apps/pillarx-app/index.tsx), a Hyperliquid promo tile linking to/perps. Left in place since this PR is scoped to the Apps section — shout if that should go too.