Skip to content

ci: add prow OWNERS file for the critical files - #1523

Merged
ti-chi-bot merged 1 commit into
masterfrom
timz/conf_owner
Sep 3, 2026
Merged

ti-chi-bot merged 1 commit into
masterfrom
timz/conf_owner

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated proto file approval routing to use a consistent default approval path.
    • Refreshed the designated approver list for protocol buffer changes.

@ti-chi-bot

ti-chi-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign terry1purcell, yudongusa for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
ti-chi-bot Bot requested a review from TszKitLo40 August 27, 2026 01:45
@ti-chi-bot ti-chi-bot Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 27, 2026
@ti-chi-bot

Copy link
Copy Markdown
Member Author

/hold

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 66522e02-9afa-49e1-b030-56db1e4ed0c7

📥 Commits

Reviewing files that changed from the base of the PR and between b6cdca1 and 3dc8770.

📒 Files selected for processing (2)
  • OWNERS_ALIASES
  • proto/OWNERS

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The change updates the sig-approvers-pb alias membership and removes per-proto approver filters. All proto files now use the fallback sig-approvers-pb approver group.

Changes

Proto ownership routing

Layer / File(s) Summary
Update proto approver alias
OWNERS_ALIASES
The sig-approvers-pb alias removes yudongusa and adds likidu, hbisheng, and zhaoshangzi.
Apply fallback approver routing
proto/OWNERS
The per-proto filters are commented out. The .* fallback now assigns all proto files to sig-approvers-pb.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🟡 Moderate · up to 3dc87

This change is not currently merge-ready because the PR remains on hold and lacks a linked issue; those readiness blockers should be resolved before merging.

Suggested reviewers: ghazalfamilyusa, tszkitlo40

Poem

A rabbit checked the owners list,
And found new names to add.
The proto paths now share one gate,
With fallback rules well clad.
“Hop!” said the rabbit, “reviews align!”

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title refers to the OWNERS configuration changes, but it incorrectly states that a new Prow OWNERS file was added. The changes update existing OWNERS files and alias routing rules.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch timz/conf_owner

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

Copy link
Copy Markdown
Member Author

/unhold

@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2026
@ti-chi-bot

Copy link
Copy Markdown
Member Author

/release-note-none

@ti-chi-bot ti-chi-bot Bot added lgtm approved skip-issue-check Indicates that a PR no need to check linked issue. and removed do-not-merge/needs-linked-issue labels Sep 3, 2026
@ti-chi-bot
ti-chi-bot merged commit 4f8202e into master Sep 3, 2026
7 checks passed
@ti-chi-bot
ti-chi-bot deleted the timz/conf_owner branch September 3, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants