Conversation
Add optional caller component arrays aligned with each query selector. Define header fallback for missing or mismatched arrays so receivers can attribute logical requests without splitting mixed-component batches. Regenerate Go bindings and update the protocol lock. Signed-off-by: JmPotato <github@ipotato.me>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthrough
ChangesQuery caller components
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The request can preserve per-query caller metadata while remaining compatible with existing receivers; no merge-blocking risk is currently identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. I’m a rabbit with fields in a row Comment |
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
QueryRegion can contain logical queries from different caller components, but its shared request header carries only one component. Per-query metadata lets PD attribute these queries correctly while retaining mixed batches.
Add optional
id_caller_components,key_caller_components, andprev_key_caller_componentsarrays, aligned by position withids,keys, andprev_keys. An absent or mismatched array falls back toheader.caller_component; an empty entry represents an unknown component. Existing field numbers and response encoding remain unchanged, and older receivers ignore the new fields.Update the generated Go bindings and protocol lock. Related: tikv/pd#11180.
Validation:
make go(protocol formatting, compatibility checks, generation, module tidy, and Go build),go build ./pkg/..., andgo test ./pkg/pdpb ./pkg/routerpb.Summary by CodeRabbit