Skip to content

chore(go): require Go 1.25.14 on release-8.5 - #1546

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:release-8.5from
wfxr:backport/pr-1540-release-8.5
Sep 24, 2026
Merged

ti-chi-bot[bot] merged 1 commit into
pingcap:release-8.5from
wfxr:backport/pr-1540-release-8.5

Conversation

@wfxr

@wfxr wfxr commented Sep 24, 2026

Copy link
Copy Markdown
Member

Summary

Backport #1540 to release-8.5 by raising the required Go version in go.mod from 1.19 to 1.25.14. Add the go.sum entry produced by go mod tidy under Go 1.25.14 so the release branch's Go CI check remains clean.

Related issue: #1541.

Testing

  • go test ./... with Go 1.25.14
  • go mod tidy -diff with Go 1.25.14
  • git diff --check

Summary by CodeRabbit

  • Chores
    • Updated the project’s Go runtime baseline. This is an underlying compatibility change; no changes to application features or user-facing behavior are included in this update.

Backport pingcap#1540 to align the release branch with the
required Go patch version. Record the checksum needed for a clean
module tidy with that version.
@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 24, 2026
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 6c14efba-a52e-4363-82d1-5592a8736016

📥 Commits

Reviewing files that changed from the base of the PR and between ab27878 and 5f0b8c9.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The module's Go version directive changed from 1.19 to 1.25.14.

Changes

Go version directive

Layer / File(s) Summary
Update Go version directive
go.mod
The module's Go version directive changed from 1.19 to 1.25.14.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 5f0b8

The Go requirement is raised to the stated version, and the supplied context identifies no actionable merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: requiring Go 1.25.14 on the release-8.5 branch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

I’m a rabbit, ears held high,
I hop where newer Go versions lie.
One small directive changed its place,
A fresh version joins the case.
I nibble clover, then I cheer,
The module’s version now reads clear.

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 24, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cfzjywxk,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 24, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 24, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-24 07:31:09.284534743 +0000 UTC m=+262794.509755851: ☑️ agreed by cfzjywxk.
  • 2026-09-24 07:39:12.288684094 +0000 UTC m=+263277.513905191: ☑️ agreed by lcwangchao.

@ti-chi-bot
ti-chi-bot Bot merged commit 24a8241 into pingcap:release-8.5 Sep 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants