chore(go): require Go 1.25.14 on release-8.5 - #1546
Conversation
Backport pingcap#1540 to align the release branch with the required Go patch version. Record the checksum needed for a clean module tidy with that version.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe module's Go version directive changed from ChangesGo version directive
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to The Go requirement is raised to the stated version, and the supplied context identifies no actionable merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. I’m a rabbit, ears held high, Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Summary
Backport #1540 to
release-8.5by raising the required Go version ingo.modfrom 1.19 to 1.25.14. Add thego.sumentry produced bygo mod tidyunder Go 1.25.14 so the release branch's Go CI check remains clean.Related issue: #1541.
Testing
go test ./...with Go 1.25.14go mod tidy -diffwith Go 1.25.14git diff --checkSummary by CodeRabbit