proto: add NDV rate to analyze request#410
Merged
Merged
Conversation
2 tasks
0xPoe
added a commit
to 0xPoe/tikv
that referenced
this pull request
May 14, 2026
…tches Add row-level Bernoulli sampling to the table scan executor so ANALYZE can build distinct-value sketches from a subset of rows. The sampling rate is taken from the new AnalyzeColumnsReq.ndv_rate field (pingcap/tipb#410); when it is unset, the scanner keeps every row. Build an F1 (singleton) sketch alongside the FM sketch and report it with sketch_sample_count in the row collector. Null counts and total sizes are rescaled from the sampled rows back to the full row count. Signed-off-by: 0xPoe <techregister@pm.me>
winoros
approved these changes
May 15, 2026
Member
Author
|
Thanks for your review! 💚 💙 💜 💛 ❤️ |
Ari4ka
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref pingcap/tidb#67449
What changed
AnalyzeColumnsReq.ndv_ratefor NDV sampling rate.Tests
make check