Allow SPIFFEs to create keys#89
Open
KevinHock wants to merge 4 commits into
Open
Conversation
Also add the ability to specify ACL on creation
KevinHock
force-pushed
the
spiffe_makin_keys
branch
from
February 6, 2023 22:43
1263015 to
c02efd7
Compare
Because we are not checking for typos in the provided user or group names, we require 2 of more human principles to be in the ACL of a SPIFFE-made Knox key.
KevinHock
force-pushed
the
spiffe_makin_keys
branch
from
February 6, 2023 23:21
c629e54 to
a59b437
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add the ability to specify ACL on creation, resolving
knox/client/create.go
Line 58 in ad06773