Skip to content

Upgrade to Node 24 for npm OIDC Trusted Publishers#16

Merged
pipedrive-public-gha-bot[bot] merged 1 commit into
masterfrom
CICDL-347-upgrade-node
May 21, 2026
Merged

Upgrade to Node 24 for npm OIDC Trusted Publishers#16
pipedrive-public-gha-bot[bot] merged 1 commit into
masterfrom
CICDL-347-upgrade-node

Conversation

@Moser-ss
Copy link
Copy Markdown
Contributor

Summary

  • Update .nvmrc from 22 to 24 — Node 24 bundles npm 11.x which supports OIDC authentication required by Trusted Publishers (npm 10.x bundled with Node 22 does not)
  • Add supported_versions: '[20,22]' to publish workflow
  • Regenerated package-lock.json with Node 24

Test plan

  • CI passes (lint, typecheck, tests) on Node 24
  • Publish workflow triggers correctly with OIDC on next labeled PR

🤖 Generated with Claude Code

…blishers

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 21, 2026 14:47
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s Node.js toolchain to Node 24 to pick up npm 11.x support needed for npm OIDC authentication with Trusted Publishers, and regenerates the lockfile accordingly.

Changes:

  • Bumped .nvmrc from Node 22 to Node 24 (CI will now run using Node 24 via node-version-file).
  • Updated the publish workflow inputs (added supported_versions).
  • Regenerated package-lock.json with the newer Node/npm toolchain metadata.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
package-lock.json Lockfile regenerated; includes updated package metadata fields from newer npm.
.nvmrc Sets the repository’s Node version to 24 (affects local dev and CI).
.github/workflows/publish.yml Adds supported_versions input to the reusable npm publish workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

uses: pipedrive-actions/github-actions-workflows/.github/workflows/reusable_cicd-npm-publish.yml@master
with:
revision: ${{ github.event.pull_request.head.ref }}
supported_versions: '[20,22]'
pipedrive-public-gha-bot Bot pushed a commit that referenced this pull request May 21, 2026
@pipedrive-public-gha-bot pipedrive-public-gha-bot Bot merged commit 48d53f7 into master May 21, 2026
11 of 12 checks passed
@pipedrive-public-gha-bot pipedrive-public-gha-bot Bot deleted the CICDL-347-upgrade-node branch May 21, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants