Skip to content

JBRes-1797 LocalHistory Snapshot - #56

Draft
Mike-Wazovsky wants to merge 19 commits into
mainfrom
sbone/snapshot-refactoring
Draft

JBRes-1797 LocalHistory Snapshot#56
Mike-Wazovsky wants to merge 19 commits into
mainfrom
sbone/snapshot-refactoring

Conversation

@Mike-Wazovsky

@Mike-Wazovsky Mike-Wazovsky commented Jan 27, 2025

Copy link
Copy Markdown
Collaborator

Git snapshot

This PR implements classes GitWrapperService and ProjectGitSnapshotManager which are responsible for Git and its usage for snapshots.

This PR actually is an inheritance of older PR JBRes-1796 Git Snapshot Impl which was adapted for new snapshot logic after refactors.

How to test

Automated tests

see GitWrapperTest and ProjectGitSnapshotManagerTest

Manual tests

You can test it manually by setting Snapshot strategy as PROJECT_GIT.

Self-check list

  • PR title and description are clear and aligned with a format.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date/provided.
  • The link to this PR is commented on in the corresponding YT ticket.

Hint: [x] is a marked item

@SBOne-Kenobi SBOne-Kenobi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's needed to fix tests only

SBOne-Kenobi
SBOne-Kenobi previously approved these changes Jan 29, 2025
@SBOne-Kenobi
SBOne-Kenobi self-requested a review January 29, 2025 14:23
@SBOne-Kenobi
SBOne-Kenobi dismissed their stale review January 29, 2025 14:25

Need to check libs + delete excluding of tests

Comment thread build.gradle.kts Outdated
Comment thread docs/SnapshotManagers.md Outdated
Comment thread gradle/libs.versions.toml Outdated
Comment thread gradle/libs.versions.toml Outdated
Comment thread project-minimization-plugin/build.gradle.kts Outdated
Comment thread project-minimization-plugin/src/main/resources/META-INF/plugin.xml Outdated
# Conflicts:
#	docs/SnapshotManagers.md
#	project-minimization-plugin/src/main/kotlin/org/plan/research/minimization/plugin/Util.kt
#	project-minimization-plugin/src/main/kotlin/org/plan/research/minimization/plugin/context/snapshot/impl/ProjectLocalHistorySnapshotManager.kt
#	project-minimization-plugin/src/main/kotlin/org/plan/research/minimization/plugin/model/state/SnapshotStrategy.kt
#	project-minimization-plugin/src/main/kotlin/org/plan/research/minimization/plugin/services/MinimizationStageExecutorService.kt
#	project-minimization-plugin/src/test/kotlin/snapshot/ProjectCloningSnapshotTest.kt
@SBOne-Kenobi SBOne-Kenobi changed the title JBRes-1796 Git Snapshot JBRes-1797 LocalHistory Snapshot Mar 10, 2025
@SBOne-Kenobi
SBOne-Kenobi marked this pull request as draft March 10, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants