Conversation
Add steps 5 and 6 to bootstrap-provider.md covering the three-resource requirement for Marketplace visibility (ProviderMetadata + APIExport with at least one schema + ContentConfiguration, all linked by the ui.platform-mesh.io/content-for label) and the bind ClusterRole/ ClusterRoleBinding required for the Enable button to work. Add the ui.platform-mesh.io/content-for label to the metadata-catalog labels table with a cross-reference to the new how-to steps. These gaps were discovered while validating the HSP → Platform Mesh extension migration end-to-end on a local kind cluster. Signed-off-by: Leidy Garzon <leidy.garzon@sap.com>
platform-mesh/platform-mesh#332 fixes the Marketplace filter to use status.identityHash instead of len(latestResourceSchemas), so UI-only providers no longer need a dummy APIResourceSchema to appear in the Marketplace. Update the example accordingly. Signed-off-by: Leidy Garzon <leidy.garzon@sap.com>
…iderMetadata name The content-for label has two different values depending on the resource: - ProviderMetadata and APIExport: content-for: <ProviderMetadata.name> (joins them for Marketplace listing, filter.go:219) - ContentConfiguration: content-for: <APIExport.name> (projects nav into consumer workspace after install, filter.go:144) Previously the doc incorrectly stated all three resources share the same value. Verified against virtual-workspaces/pkg/storage/filter.go and the github provider in local-setup (APIExport has content-for: github, CC has content-for: github.dxp.sap.com). Signed-off-by: Leidy Garzon <leidy.garzon@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
how-to-guides/bootstrap-provider.mddocumenting:ProviderMetadata+APIExport+ContentConfiguration) and how theui.platform-mesh.io/content-forlabel joins them — with different values per resource (see below).bindClusterRole/ClusterRoleBindingrequired for the Enable button to work.ui.platform-mesh.io/content-forto the labels table inreference/resources/metadata-catalog.md, which previously omitted it entirely.Key finding: content-for has two different values
The
content-forlabel serves two independent join operations with different values:content-forvalueProviderMetadata+APIExport<ProviderMetadata.name>e.g.my-servicefilter.gojoins these two by this valueContentConfiguration<APIExport.name>e.g.my-service.example.comfilter.gojoins by the APIExport name from the APIBindingVerified in
virtual-workspaces/pkg/storage/filter.go:144(CC lookup) andfilter.go:219(Marketplace listing), and against thegithubprovider in local-setup (APIExport hascontent-for: github, CC hascontent-for: github.dxp.sap.com).Motivation
A provider author following the existing docs would end up with a workspace that has all the right resources but whose card never appears in the Marketplace and whose nav nodes never project into consumer workspaces — with no error to explain why. Neither the
content-forlabel nor the bind RBAC requirement were documented anywhere.Note: the original gap also included a
len(latestResourceSchemas) == 0filter that blocked UI-only providers — that is fixed separately in platform-mesh/platform-mesh#332. This docs PR reflects the corrected behavior (UI-only exports with no schemas are valid onceidentityHashis set).Discovered while validating the HSP → Platform Mesh extension migration end-to-end on a local kind cluster (DXPFRAME-2475).
Test plan
npm run buildpasses## Relatedpresent)