Skip to content

chore: drop the unused package skeleton residue - #22

Merged
danielebarbaro merged 1 commit into
mainfrom
chore/drop-skeleton-residue
Sep 8, 2026
Merged

chore: drop the unused package skeleton residue#22
danielebarbaro merged 1 commit into
mainfrom
chore/drop-skeleton-residue

Conversation

@danielebarbaro

Copy link
Copy Markdown
Contributor

This package parses XML. It has no Eloquent models, no migrations and no views. It was still carrying the scaffolding for all three from the spatie package skeleton it was generated from.

What was there

database/factories/ModelFactory.php defined nothing. The entire class body was inside a comment block:

namespace PlinCode\KmlParser\Database\Factories;

use Illuminate\Database\Eloquent\Factories\Factory;

/*
class ModelFactory extends Factory
{
    protected $model = YourModel::class;
    // ...
}
*/

So PlinCode\KmlParser\Database\Factories\ModelFactory has never existed as a class. The file was a namespace declaration and an unused import, with a PSR-4 autoload entry in composer.json pointing at it.

tests/TestCase.php aimed Eloquent's factory name resolution at that empty namespace in setUp(), and carried a commented-out migration loop in getEnvironmentSetUp().

resources/views/ held a single .gitkeep. The service provider only calls hasConfigFile(), so no view is ever registered or published.

phpstan.neon.dist listed database as a path to analyse and set checkModelProperties: true, a rule about Eloquent models, of which there are none.

What changed

  • deleted database/ and resources/
  • dropped the PlinCode\KmlParser\Database\Factories\ PSR-4 entry from composer.json
  • dropped database from the PHPStan paths and removed checkModelProperties
  • reduced TestCase to the one thing it actually does, registering the service provider

checkOctaneCompatibility: true stays. That one is relevant, the parser holds request state.

Risk

Nothing referenced any of it, and the one class that could have been referenced was never defined. Suite still 65 passing, PHPStan [OK] No errors, Pint clean.

The removed autoload entry means composer dump-autoload produces a slightly smaller classmap. Nothing else observable changes.

The package has no Eloquent models and ships no views, but it still
carried the scaffolding for both from the spatie skeleton it was
generated from.

database/factories/ModelFactory.php defined nothing at all: the class
body sat inside a comment block, so the file was an empty namespace
declaration that the composer autoloader was nevertheless mapped to.
resources/views held only a .gitkeep. TestCase pointed Eloquent's
factory name resolution at that empty namespace and carried a
commented-out migration loop. PHPStan was told to check model properties
and to analyse the database directory.

None of it was reachable. Removing it is a no-op.
@danielebarbaro
danielebarbaro merged commit 93809bc into main Sep 8, 2026
19 checks passed
@danielebarbaro
danielebarbaro deleted the chore/drop-skeleton-residue branch September 8, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant