Skip to content

ci(rector): run the refactoring check on every build #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielebarbaro merged 2 commits into from
Sep 8, 2026
Merged

ci(rector): run the refactoring check on every build #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c85c88
ci(rector): run the refactoring check on every build
danielebarbaro Sep 8, 2026
344e3dc
build(rector): require the versions the config depends on
danielebarbaro Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ jobs:
- name: Linter
run: composer lint:check

- name: Rector
if: runner.os != 'Windows'
run: composer rector:check

- name: Type Coverage
if: runner.os != 'Windows'
run: composer test:types
Expand Down
20 changes: 14 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,14 +758,22 @@ the filter that serves it, since the built in filter refuses an operation it doe
composer test
```

That runs static analysis, the formatting check, the type coverage check and the test
suite. Each step is also available on its own:
That runs static analysis, the formatting check, the refactoring check, the type coverage
check and the test suite. Each step is also available on its own:

```bash
composer analyse # PHPStan
composer lint:check # Pint, in check mode
composer test:types # Pest type coverage
composer test:unit # Pest
composer analyse # PHPStan
composer lint:check # Pint, in check mode
composer rector:check # Rector, as a dry run
composer test:types # Pest type coverage
composer test:unit # Pest
```

`composer lint` applies the formatting rather than checking it. Rector has no apply script
on purpose, so a refactoring it proposes is read before it is taken:

```bash
vendor/bin/rector process
```

## Contributing
Expand Down
5 changes: 3 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"spatie/laravel-query-builder": "^7.3.1"
},
"require-dev": {
"driftingly/rector-laravel": "^2.0",
"driftingly/rector-laravel": "^2.6",
"larastan/larastan": "^3.9",
"laravel/pao": "^1.0",
"laravel/pint": "^1.29",
Expand All @@ -42,7 +42,7 @@
"phpstan/extension-installer": "^1.4",
"phpstan/phpstan-deprecation-rules": "^2.0",
"phpstan/phpstan-phpunit": "^2.0",
"rector/rector": "^2.0"
"rector/rector": "^2.6"
},
"autoload": {
"psr-4": {
Expand Down Expand Up @@ -94,6 +94,7 @@
"test": [
"@analyse",
"@lint:check",
"@rector:check",
"@test:types",
"@test:unit"
],
Expand Down