feat: add internal flag to Endpoint create params (VT-9534) - #324
Closed
revanth-plivo wants to merge 2 commits into
Closed
feat: add internal flag to Endpoint create params (VT-9534)#324revanth-plivo wants to merge 2 commits into
revanth-plivo wants to merge 2 commits into
Conversation
Adds an optional `internal` boolean field to `EndpointCreator` so callers can mark newly created SIP endpoints as internal at creation time. Trace already accepts the `internal` column on the endpoint model and defaults the List API to hide internal endpoints. This SDK change unblocks Plivo CX (Contacto) from tagging auto-created browser-SDK endpoints so they stop leaking into the customer's Endpoints tab (Pylon #2460). When `internal` is not set, Jackson omits it from the serialized JSON, so existing callers see identical wire behavior.
revanth-plivo
force-pushed
the
VT-9534-add-internal-endpoint-flag
branch
from
July 27, 2026 12:32
2e30b02 to
600631b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
internalboolean builder param toEndpointCreatorso callers can mark newly created SIP endpoints as internal at creation time.Why
Plivo CX (Contacto) auto-creates a SIP endpoint per AOM during user invite for browser-SDK playback. These internal endpoints currently leak into the customer's Endpoints tab in the console (Pylon #2460), causing confusion, prod alerts (customers try to register the SIP from third-party clients), and a security concern (customer can silently change creds).
The trace service already supports an
internalcolumn on the endpoint model + defaults the List API to exclude internal endpoints (commitcea50cf/d425930on trace). What's missing is the ability for the auto-create call (Hodor) to actually mark endpoints asinternal=trueat creation time. This SDK change unblocks that.Change
EndpointCreator.java— one new optional builder param:private Boolean internal;public EndpointCreator internal(final Boolean internal) { ... }public Boolean internal() { ... }accessorinternal(Jackson snake_case naming strategy leaves the single-word field unchanged)5.49.0->5.49.1inpom.xmlandversion.txt; matchingCHANGELOG.mdentryBackwards-compatibility
internalis a boxedBooleanthat defaults tonulland is omitted from the serialized JSON when unset. Every existing caller sees identical wire behavior. Only callers that explicitly call.internal(true)opt into the new path.Test plan
mvn compileclean (validated by CI)EndpointTestsuite passesapi.plivo.comcreate endpoint withinternal=truefrom a test account and verifysubscriber.internal = trueon the row (validated separately by the CX team's integration)Related
🤖 Generated with Claude Code