Skip to content

perf(vcs): reduce git process count in git fallback from 5 to 3 - #47

Merged
plttn merged 1 commit into
mainfrom
perf/vcs-reduce-git-processes
Jul 8, 2026
Merged

perf(vcs): reduce git process count in git fallback from 5 to 3#47
plttn merged 1 commit into
mainfrom
perf/vcs-reduce-git-processes

Conversation

@plttn

@plttn plttn commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Summary

Ports the git-subprocess-reduction optimization from IlanCosman/tide#663 (by @lgeiger, still open upstream) into this fork's git fallback path in functions/_tide_item_vcs.fish.

When git/jj got unified into _tide_item_vcs (v7.0.13), the git-handling logic was carried over verbatim from the old pre-#663 _tide_item_git.fish — 5 git processes per render (git branch --show-current, git rev-parse --git-dir --is-inside-git-dir, git status --porcelain, git stash list, git rev-list --count --left-right @{upstream}...HEAD). This never got the upstream fix since that PR hasn't merged.

Adding --branch to git status --porcelain puts a header line first in the output (e.g. ## main...origin/main [ahead 2, behind 1]) that already contains the branch name and ahead/behind counts, eliminating two of the five calls:

  • Branch name is now parsed from that header (falling back to the old branch/tag/detached-HEAD cascade only when the header doesn't yield a usable name, e.g. detached HEAD)
  • Ahead/behind come from a regex lookbehind on the same header instead of a separate git rev-list call
  • git stash list stays, since git status can't report stash count

Result: 3 git processes instead of 5, same observable output. Only the git fallback path is touched — the jj path (_tide_internal_jj_git) is untouched.

Test plan

  • mise run lint / fish_indent --check pass
  • mise run test — full suite passes, including _tide_item_vcs.test.fish (branch names, detached HEAD, tags, ahead/behind, stash, staged/dirty/untracked, submodules, massive-status-repo)
  • Updated the massive-status-repo test fixture to mock --branch and return a synthetic ## main header line, matching upstream's own test update in #663

🤖 Generated with Claude Code

Ports the optimization from IlanCosman/tide#663 (by @lgeiger, still open
upstream) into the git fallback in _tide_item_vcs.fish, which had inherited
the pre-#663 implementation verbatim from the git/jj unification.

Adding --branch to `git status --porcelain` puts a header line like
`## main...origin/main [ahead 2, behind 1]` first in the output, which
already contains the branch name and ahead/behind counts. That removes the
need for the separate `git branch --show-current` and
`git rev-list --count --left-right @{upstream}...HEAD` calls, folding
location detection into the same status call in the common case and only
falling back to the old branch/tag/detached-HEAD cascade when the header
doesn't yield a usable name (detached HEAD). `git stash list` stays as its
own call since status can't report stash count.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@plttn
plttn merged commit 8b7735b into main Jul 8, 2026
7 checks passed
plttn pushed a commit that referenced this pull request Jul 8, 2026
🤖 I have created a release *beep* *boop*
---


## [7.0.16](v7.0.15...v7.0.16)
(2026-07-08)


### Bug Fixes

* **pwd:** only clear glob when contains fails, not unconditionally
([#43](#43))
([5837b85](5837b85))


### Performance Improvements

* **vcs:** reduce git process count in git fallback from 5 to 3
([#47](#47))
([8b7735b](8b7735b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@plttn
plttn deleted the perf/vcs-reduce-git-processes branch July 18, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant