fix: prevent PDF export crash on tables with nested quotes in inline styles - #86
Open
Herafia wants to merge 5 commits into
Open
fix: prevent PDF export crash on tables with nested quotes in inline styles#86Herafia wants to merge 5 commits into
Herafia wants to merge 5 commits into
Conversation
Rom1-B
requested changes
Aug 25, 2026
|
|
||
| // Remove table-layout:fixed style (prevents auto-sizing) | ||
| $html = preg_replace('/table-layout\s*:\s*fixed\s*;?/i', '', $html); | ||
| // Parse with DOMDocument rather than regexes: style/attribute values coming |
There was a problem hiding this comment.
Can you add a unit test for cleanTableHtml() with a nested-quote url('...') style value (case from !45825)? Verified locally that the old regex code produced a <table> with duplicate border/style attributes on this input, the actual crash mechanism, and that the new code doesn't; a test would pin the regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Fix: Replaced the regular expressions with DOMDocument/DOMXPath parsing in cleanTableHtml, which is robust against nested quotes.