Fix File::GlobMapper wildcard replacement after ordinary letters#76
Merged
Conversation
The eval-removal change used a single-quoted negative lookbehind
containing ${BEGIN_DELIM}. That made the regex treat the characters in the
literal string "${BEGIN_DELIM}" as excluded preceding characters, so output
patterns such as B#1.out or IMG#1.out did not expand pmqs#1.
Escaped literal # and * are already protected with HASH_ESC and STAR_ESC
before wildcard references are converted to internal markers, so the
lookbehind is not needed. Replace exact internal marker sequences directly
when generating output filenames.
Add a regression test for expanding pmqs#1 after an ordinary letter.
Owner
|
Thanks @vlmarek the change looks fine, but I'll need to remind myself about that area of code. Will be a few days as my dev box is not working properly. Extra bonus points for creating a test for the fix! thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eval-removal change used a single-quoted negative lookbehind containing ${BEGIN_DELIM}. That made the regex treat the characters in the literal string "${BEGIN_DELIM}" as excluded preceding characters, so output patterns such as B#1.out or IMG#1.out did not expand #1.
Escaped literal # and * are already protected with HASH_ESC and STAR_ESC before wildcard references are converted to internal markers, so the lookbehind is not needed. Replace exact internal marker sequences directly when generating output filenames.
Add a regression test for expanding #1 after an ordinary letter.