feat(probable): implement unified Web3 authentication lifecycle#1614
feat(probable): implement unified Web3 authentication lifecycle#1614AbhilashG12 wants to merge 5 commits into
Conversation
- Add AuthNonceResponse, AuthLoginResponse, AuthSession types - Add getAuthNonce, loginWithSignature, logout to BaseExchange - Implement Probable auth with callApi() pattern - Add verifyL1 and verifyL2 for signature verification - Add OpenAPI endpoints for all auth operations - Add unit tests for auth lifecycle (5 tests passing) - Update generator to recognize auth types - Regenerate SDKs and docs Fixes pmxt-dev#1606
- Add AuthNonceResponse and AuthLoginResponse to TYPE_MAP - Regenerate Python client with auth methods Fixes pmxt-dev#1606
PR Review: FAILWhat This DoesAdds a unified Web3 authentication lifecycle ( Blast RadiusCore Consumer VerificationBefore (base branch): After (PR branch): const { ProbableExchange } = require('./core/dist/exchanges/probable');
const ex = new ProbableExchange();
await ex.getAuthNonce('0x1234567890123456789012345678901234567890');Result: The built exchange's generated implicit methods are named Test Results
Findings
PMXT Pipeline Check
Semver Impactminor -- adds new SDK/core auth methods. RiskThe advertised SDK methods are currently unusable until the Probable auth helpers call the actual generated implicit method names or the API spec is given stable operation IDs that match the helpers. |
- getNonce → getPublicApiV1AuthNonce - postLogin → postPublicApiV1AuthLogin - postLogout → postPublicApiV1AuthLogout - postVerifyL1 → postPublicApiV1AuthVerifyL1 - postVerifyL2 → postPublicApiV1AuthVerifyL2 Fixes pmxt-dev#1606
|
Fixed |
Fixes #1606