fix(ts-sdk): make history params optional#1617
Open
realfishsam wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the TypeScript SDK's
fetchOHLCVandfetchTradeshistory-filter argument optional, matching the Python SDK and preventing one-argument calls from dereferencingundefined.fetchOHLCVnow also omits an unsetresolutionfrom the sidecar query instead of serializing an undefined field.Fixes #1556
Test plan
npm test --workspace=pmxtjs -- --runTestsByPath tests/history-optional-params.test.ts --runInBandfailed with TS2554 because both methods required a second argument.npm test --workspace=pmxtjs -- --runInBand(17 suites, 86 tests passed).node sdks/typescript/scripts/generate-client-methods.jsgit diff --checkThe checkout does not contain committed generated TypeScript client artifacts, so local Jest used a temporary untracked
sdks/typescript/generated/src/index.tsimport stub. The stub was removed before staging and is not part of this PR.