fix(cli): support run-steps SDK method migration#87
Merged
Conversation
The `if: env.SLACK_WEBHOOK_URL != ''` guard read a step-level env var, which GitHub does not expose to that same step's `if` (only workflow/job env is visible). The gate always evaluated empty, so notify-approval, notify-success, and notify-failure always took the skip branch and never posted to Slack. Hoist SLACK_WEBHOOK_URL to job-level env on all three jobs so the gate resolves. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
podonos-eunseo
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility bridge
workflows.runs.stepsthe canonical CLI SDK method pathworkflows.get_run_stepsonly when the canonical attribute is genuinely absentContract coverage
This bridges the current production SDK shape and the intentional PR #444 rename so regeneration can succeed from backend SHA
e9a5532fb90b344901b65f004f26c4d5df90494a.Test Coverage
onepin._clicoverage: 93.44%Pre-Landing Review
No issues found. Independent code/spec/security and architecture/adversarial lanes both returned clear/approve on
b7f74c2.Design Review
No frontend files changed; design review skipped.
Eval Results
No prompt-related files changed; evals skipped.
Greptile Review
No Greptile comments.
Scope Drift
Scope Check: CLEAN. The effective PR diff contains only the two hand-written CLI files and their two test files. The branch history retains commits from an already-merged PR, but those files are not present in this PR's diff.
Plan Completion
The compatibility bridge is complete. Regeneration, generated-client inspection, and release refresh remain intentionally merge-gated downstream steps.
Verification Results
uv run ruff check src/onepin/_cli testsuv run ruff format --check src/onepin/_cli testsuv run pytest -q --cov=onepin._cli --cov-report=xml --cov-fail-under=80uv run diff-cover coverage.xml --compare-branch=origin/mainuv run python -m buildTest plan
e9a5532fb90b344901b65f004f26c4d5df90494a.spec-sha, generated method parameters, preservation guards, and CIRelease sequencing
After this PR lands, rerun
regen.ymlwith SHAe9a5532fb90b344901b65f004f26c4d5df90494aand verify the new regen PR. Keep release PR #86 unmerged until release-please includes both this bridge and the successful PR #444 SDK regeneration.Removal criterion: remove the legacy CLI fallback after
0.12.0, the first release containingworkflows.runs.steps, ships and regeneration no longer needs compatibility with the pre-rename SDK shape.