security(batch2): guard mergeDeep against prototype-pollution keys (#8)#1
Merged
Merged
Conversation
The advanced-JSON escape hatch deep-merges user-supplied input via mergeDeep. Skip __proto__/constructor/prototype keys so a crafted advanced payload cannot reassign the result object's prototype. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security audit batch 2 — #8 (prototype-pollution guard in the shared mergeDeep).
The advanced-JSON escape hatch deep-merges user-supplied input.
mergeDeepskipped no keys, so a
{"__proto__":{...}}payload (an own key when it arrivesvia JSON) reassigned the merged object's prototype. Added a guard that skips
__proto__/constructor/prototype.Real blast radius is small (the merge is non-mutating, so it never polluted the
global
Object.prototype); this is a defense-in-depth / consistency fix appliedacross all the connectors.
Test: a malicious payload no longer reaches the prototype, legit keys still
merge. Fails without the guard. tsc clean.
🤖 Generated with Claude Code