PB-15811 | Helm 4 changes to move CRD installation from helm to operator#930
Open
vk-px wants to merge 2 commits into
Open
PB-15811 | Helm 4 changes to move CRD installation from helm to operator#930vk-px wants to merge 2 commits into
vk-px wants to merge 2 commits into
Conversation
vk-px
marked this pull request as draft
June 16, 2026 09:45
vk-px
changed the title
vk-px
marked this pull request as ready for review
June 22, 2026 06:54
px-kesavan
approved these changes
Jul 6, 2026
vk-px
force-pushed
the
PB-15811-final
branch
2 times, most recently
from
July 15, 2026 07:09
3b42ba9 to
a87988f
Compare
px-kesavan
reviewed
Jul 20, 2026
| "helm.sh/hook": pre-install | ||
| "helm.sh/hook-weight": "6" | ||
| "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded,hook-completed | ||
| "argocd.argoproj.io/hook": PreSync |
Collaborator
There was a problem hiding this comment.
Why this has been set explicitly ?
Should we have the same in the dependent resources as well , monitoring cr configmap and RBAC?
There are helm hook annotations and argocd hook annotations , please look at it . Here we are using both
"helm.sh/hook": pre-install
"argocd.argoproj.io/hook": PreSync
Explore on the ordering , i guess any one will be honored , so lets align with the dependent resources as well
Collaborator
|
@vk-px Can you install just the PXcentral charts and attach the screenshots |
Author
@px-kesavan , this was indeed an orphan from one of our previous experiments, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PB-15811 | Helm 4 changes to move CRD installation from helm to operator
this is to help better debug and exert better control on the installation process in px-backup
Special notes for your reviewer:
BYOC run results https://jenkins.pwx.purestorage.com/blue/organizations/jenkins/Users%2FVaisakh%2Fhelm4-upgrade-pipeline/detail/helm4-upgrade-pipeline/27/pipeline,
this is a custom pipeline testing for install and upgrade using helm 4 with 3.2.0
not all of the tests are running , where we have to call out in the documentation that only 3.2.0 or above is supported with helm 4.
BYOC RUNS for Install & Upgrade:
pipeline runs using the changes from PB-15811 (#930):
BYOC Install & Upgrade pipeline run results https://jenkins.pwx.purestorage.com/job/Users/job/Vaisakh/job/pxb-install-upgrade-helm4/52/ (this is the test results for Helm Install)
https://jenkins.pwx.purestorage.com/job/Users/job/Vaisakh/job/pxb-install-upgrade-helm4/58/ (One test failed due to Network issue, all the other runs are working for ARGOCD installation )
please note ArgoCD only uses helm template command as such helm 3 and 4 does not have a very good impact on it, we are using it just to ensure that there wont be any installation issues.