Extract out Writing Tests to document nextest processes#1281
Open
DavisVaughan wants to merge 3 commits into
Open
Extract out Writing Tests to document nextest processes#1281DavisVaughan wants to merge 3 commits into
Writing Tests to document nextest processes#1281DavisVaughan wants to merge 3 commits into
Conversation
lionel-
approved these changes
Jun 23, 2026
lionel-
left a comment
lionel-
left a comment
Contributor
There was a problem hiding this comment.
Approving but I'd make a bit terser for reasons explained inline.
|
|
||
| Prefer simple assertion macros without custom error messages: | ||
|
|
||
| ```rust |
Contributor
There was a problem hiding this comment.
I'm a bit worried about overloading our agents file with test styling instructions. So I'd prefer making this section terser. It's normal for past instructions to get increasingly ignored as the context gets longer anyway, but we pay the cost of the base agents prompt on every exchange (much less when cached but it's easy for the cache to get flushed).
If styling is super important the best way is to extract in a skill for the reviewing agent, because then the instructions will be fresh and the focus of the agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't actually say in AGENTS.md that nextest means we don't have to worry about test hygiene, so lets give this a try? Might also give us a place to document other test specific conventions