Skip to content

Rename all instances of the Connect class in arguments to client #467

Description

@toph-allen

Throughout the package, arguments and objects denoting the Connect client use different names.

src

connectapi/R/get.R

Lines 218 to 225 in 2522605

get_content <- function(
src,
guid = NULL,
owner_guid = NULL,
name = NULL,
...,
.p = NULL
) {

connect

content_item <- function(connect, guid) {

client is used elsewhere.

con is also used as a variable name internally, but this can be confusing if it occurs in contexts when content is also an object.

We should pick a single name, especially for user-facing arguments. I think client is better than src.

To maintain backward compatibility with existing code, we could look for the old name in ... if the first arg is missing.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions