Skip to content

Introduce Drafts page and automatic CF creation #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelteF merged 8 commits into from
Jun 15, 2025
Merged

Introduce Drafts page and automatic CF creation #70

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
90792d1
Introduce Drafts page and automatic CF creation
JelteF Jun 9, 2025
570b787
Don't automatically create commitfests in dev environments
JelteF Jun 9, 2025
975e365
Add "Returned with Feedback" and expand explanation of other patch st…
JelteF Jun 9, 2025
4fd357f
Add commet about reasoning why we update commitfests in this kinda we…
JelteF Jun 9, 2025
a29aa00
Missing word in help page
JelteF Jun 9, 2025
4c4a2c6
Automatically move patches in open CF to in progress CF if they get c…
JelteF Jun 9, 2025
f6c61e7
Fix bug setting committer
JelteF Jun 9, 2025
96b0469
Automatically move committed draft patches to the open commitfest
JelteF Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions pgcommitfest/commitfest/templates/help.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,19 @@ <h2>Patches</h2>
A "patch" is a bit of an overloaded term in the PostgreSQL community. Email threads on the mailing list often contain "patch files" as attachments, such a file is often referred to as a "patch". A single email can even contain multiple related "patch files", which are called a "patchset". However, in the context of a CommitFest app a "patch" usually means a "patch entry" in the CommitFest app. Such a "patch entry" is a reference to a mailinglist thread on which change to PostgreSQL has been proposed, by someone sending an email that contain one or more "patch files". The CommitFest app will automatically detect new versions of the patch files and update the "patch entry" accordingly.
</p>
<p>
There are three active categories of patch status:
There are three "Active" categories of patch status:
<ul>
<li>Waiting on Author - the author needs to make changes</li>
<li>Needs Reviewer - the patch needs guidance or a review</li>
<li>Ready for Committer - the patch is ready to be committed</li>
<li><b>Waiting on Author:</b> The author needs to make changes based on a review that took place on the mailinglist.</li>
<li><b>Needs Reviewer:</b> The patch needs guidance or a review.</li>
<li><b>Ready for Committer:</b> The patch has been reviewed by non-committers and is considered ready to be committed by one of those reviewers. A committer might still decide that more changes are needed.</li>
</ul>
And there are three preferred inactive categories of patch status for when
a patch has been resolved, either by being committed or not:
And there four "Closed" categories of patch status for when a patch has been
Copy link
Copy Markdown
Contributor

@polobo polobo Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And there [are] four “Closed”…

resolved, either by being committed or not:
<ul>
<li>Committed - a committer has applied the patches to the git repo</li>
<li>Withdrawn - the author has withdrawn the patch from consideration</li>
<li>Rejected - a committer has decided that the patch should not be applied</li>
<li><b>Committed:</b> A committer has applied the patches to the git repo.</li>
<li><b>Withdrawn:</b> The author has withdrawn the patch from consideration.</li>
<li><b>Rejected:</b> A committer has decided that either the feature is not desired, or the design of the patch has severe flaws. People should look at the emails on the email thread, for details on why the patch was rejected.</li>
<li><b>Returned with Feedback:</b> A committer has decided that the patch needs changes, but the author has not responded for long enough that the patch is now considered inactive. The author (or someoene else) is free to re-open again when they address the required changes.</li>
</ul>
</p>

Expand Down