Skip to content

fix(core): normalize favorite order after binding deletion - #24

Merged
postigodev merged 1 commit into
postigodev:mainfrom
huyua9:fix/normalize-favorite-order-huyua9
Sep 1, 2026
Merged

fix(core): normalize favorite order after binding deletion#24
postigodev merged 1 commit into
postigodev:mainfrom
huyua9:fix/normalize-favorite-order-huyua9

Conversation

@huyua9

@huyua9 huyua9 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

What changed

  • compact persisted favorite_order values after deleting a binding
  • preserve the existing favorite ordering while assigning contiguous positions
  • update the binding persistence regression test to cover the compacted order

Why

Deleting the first Quick Access favorite left the remaining favorite at order 2, creating a gap in persisted ordering.

Validation

  • cargo fmt --all -- --check
  • cargo test -p desk_remote_core (14 passed)
  • git diff origin/main...HEAD --check

AI-assisted; the change is limited to crates/core/src/bindings.rs.

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

@ming1523 is attempting to deploy a commit to the postigodev's projects Team on Vercel.

A member of the Team first needs to authorize it.

@postigodev
postigodev merged commit e3cc6c1 into postigodev:main Sep 1, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants