Conversation
leseb
force-pushed
the
leseb/rename-search-dispatch-filters
branch
from
September 15, 2026 09:42
0a13d78 to
43152ed
Compare
franciscojavierarceo
approved these changes
Sep 15, 2026
Align every OpenAI Responses filter with the openai_mcp_dispatch gold standard so the registered name, module path, and filter struct agree. Registered names (config-facing, breaking): - openai_responses_format -> openai_format - openai_responses_model_rewrite -> openai_model_rewrite - openai_responses_validate -> openai_validate - openai_responses_rehydrate -> openai_rehydrate - openai_responses_compact -> openai_compact - openai_responses_proxy -> openai_proxy - openai_response_store -> openai_store - responses_to_chat_completions -> openai_responses_to_chat_completions - openai_file_search_callout -> openai_file_search_dispatch - openai_web_search -> openai_web_search_dispatch Module directories renamed to match (Rust paths only): mcp_tool_resolve, tool_parse, responses_proxy, file_search_dispatch, web_search_dispatch. Filter structs renamed for consistency (e.g. StreamEventsFilter, ResponsesValidateFilter, FileSearchDispatchFilter, WebSearchDispatchFilter). Regenerated filter docs, Responses/example READMEs, and updated example configs, Makefile test filters, and integration tests to the new names. BREAKING CHANGE: filter names used in pipeline configs have changed as listed above; update `- filter: <name>` entries accordingly. This is a pre-v1 rename with no compatibility aliases. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
leseb/rename-search-dispatch-filters
branch
from
September 24, 2026 21:02
2ad2dfd to
641b31b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalizes every OpenAI Responses filter to the
openai_<feature>convention set byopenai_mcp_dispatch, so each filter's registered name, module path, and struct agree. This is a pre-v1 rename with no compatibility aliases: config-facing filter names change (e.g.openai_responses_format→openai_format,openai_response_store→openai_store,responses_to_chat_completions→openai_responses_to_chat_completions, and the search filters becomeopenai_file_search_dispatch/openai_web_search_dispatch), module directories and filter structs are renamed to match, and all generated docs, READMEs, example configs, and integration tests are updated accordingly. No behavior changes.Related issue
N/A — internal naming-consistency cleanup (no tracked issue).
Validation
cargo test -p praxis-ai-apis -p praxis-ai-filters(all pass)make buildand full-workspacecargo test --no-runmake lint(clippy, fmt, generated filter-docs, example-tests, README syncs, responses registry, inference coverage, markdown links)make docChecklist
Signed-off-bytrailer.Breaking changes
Filter names used in pipeline configs change (pre-v1, no aliases). Update
- filter: <name>entries:openai_responses_formatopenai_formatopenai_responses_model_rewriteopenai_model_rewriteopenai_responses_validateopenai_validateopenai_responses_rehydrateopenai_rehydrateopenai_responses_compactopenai_compactopenai_responses_proxyopenai_proxyopenai_response_storeopenai_storeresponses_to_chat_completionsopenai_responses_to_chat_completionsopenai_file_search_calloutopenai_file_search_dispatchopenai_web_searchopenai_web_search_dispatch