Bump the docfacts impact pin past the packages/ restructure#322
Merged
Conversation
The pinned revision predates a restructure that moved the CLI entry path, so the impact check failed with ERR_MODULE_NOT_FOUND on every PR. The new revision uses the current entry path, pins its own checkout to the same SHA so the workflow and the engine it runs move together, and makes the compute step continue-on-error so tool breakage cannot fail a PR (the check is report-only).
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| .github/workflows/docfacts-impact.yml | Updates the external Docfacts impact workflow pin and passes the matching docfacts_ref value. |
Reviews (2): Last reviewed commit: "Pin the engine ref alongside the workflo..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
The first pin's revision derived the engine checkout from github.workflow_sha, which inside a called reusable workflow resolves in the CALLER's context, so it pointed at a commit that does not exist in the tool's repo and the checkout failed. Repin to the revision that takes the ref as an explicit input and pass the same SHA for both, so the workflow file and the engine it runs stay on one commit. That revision also makes the whole job continue-on-error, so a failure in any step there cannot fail a PR here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the pinned revision of the reusable
impact.ymlworkflow from42413cfto0a45f0b.Why
The pinned revision predates a restructure that moved the CLI entry path, and it checked the tool out at a floating ref rather than a fixed one, so it ran the new tree with the old entry path. Every PR has failed the
impactcheck withERR_MODULE_NOT_FOUNDsince. The check is not required, so it never blocked merges, but it put a red X on every PR.What the new revision changes
github.workflow_sha, the same commit this pin names, so the workflow and the engine it runs can never skew apart again.continue-on-errorwith the comment step gated on its outcome, matching the workflow's documented report-only contract.Test plan
The
impactcheck on this PR exercises the new revision end to end: it should post its usual comment or pass without one, instead of failing.