ci: bump docfacts impact pin (fix reusable-workflow checkout)#323
Open
poiley wants to merge 3 commits into
Open
ci: bump docfacts impact pin (fix reusable-workflow checkout)#323poiley wants to merge 3 commits into
poiley wants to merge 3 commits into
Conversation
The old pin (42413cf) predates the docfacts packages/ restructure and its github.workflow_sha checkout tried to fetch the caller's SHA from docfacts, failing every PR's impact check. ca881c2 adds a docfacts_ref input (pins the engine to the same commit) and job-level continue-on-error.
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| .github/workflows/docfacts-impact.yml | Inlines the docfacts impact workflow with token gating, pinned docfacts checkout, impact computation, and PR comment upsert. |
Reviews (3): Last reviewed commit: "ci: inline docfacts impact job (public r..." | Re-trigger Greptile
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…le workflow) GitHub forbids a public repo from resolving a reusable workflow stored in a private repo; the call failed at startup on every run. Clone docfacts with the read PAT and run the same steps inline instead. Report-only, unchanged behavior. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
docfacts: no documented claims affected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docfacts impact check has been failing on sdks PRs: the pinned reusable workflow (42413cf) predates docfacts's packages/ restructure, and its
github.workflow_shacheckout resolves to the caller's commit — so it tried to fetch the sdks PR SHA from the docfacts repo and hard-failed.Bumps the pin to
ca881c2, which adds adocfacts_refinput (pins the engine to the same commit) and job-levelcontinue-on-errorso this report-only check can never red a PR. Mirrors the mono-repo caller fix.