Conversation
|
@ksen0 @doradocodes pls take a look, kept focused fixes as discussed (search fetch/index flow + postMessage origin hardening) |
|
@avinxshKD From my understanding, this PR includes 2 different fixes:
If that is the case, it's important that we have 2 different issues created and 2 separate PRs to fix them. This helps keep things organized for the repo. Please update the original issue #1249 to have an accurate title+description, and create a new issue if relevant. Then have 2 PRs for the each of those issues. Thanks! |
|
Hi @avinxshKD, following up on this. Are you still working on it? |
|
Hi @avinxshKD, this is the third follow-up on this PR. Are you still available to work on this? If you are facing any issues or are no longer able to continue, please let us know. Thank you for your work on this so far |
Im so sorry, was really busy with work and studies. Can i pick this up on this weekend? |
bfa5ccd to
0d7ec8f
Compare
|
@doradocodes @Nwakaego-Ego sorry this took so long. I've split the work as requested: #1249 and this PR now cover only the SearchProvider fetch/index flow PTAL when get chance :p. |
0d7ec8f to
b9c1046
Compare
|
Thank you, @avinxshKD, for your work on this PR. I tested the issue again on the live websites before reviewing the fix. Typing a search term character by character did not make repeated requests. However, submitting circle and then color produced two separate requests for the same en.json file. This confirms that the problem happens when different search terms are submitted, not on every keystroke. I also tested this PR locally:
The fix works as expected in my local testing. cc @doradocodes |
Fixes #1249
Summary
Testing
npx vitest run test/components/SearchProvider.test.tsx --project DOM --reporter=verbosenpx eslint src/components/SearchProvider/index.tsx test/components/SearchProvider.test.tsxnpm run check