fix: restore kubeconfig Secret cache invalidation - #1955
Merged
Conversation
addon-controller never picks up a kubeconfig Secret's content changing until the pod restarts. This was reproduced: point a SveltosCluster's kubeconfig Secret at a new cluster's API server and delete the old cluster. Addon-controller keeps dialing the old, now-defunct IP indefinitely (dial tcp <old-ip>:6443: i/o timeout). PR projectsveltos#1920 scoped the manager's Secret cache to type == addons.projectsveltos.io/cluster-profile (policyRef Secrets only), made unconditional. The ClusterSummaryReconciler's Secret watch is built on that same scoped informer, so a kubeconfig Secret update for a Secret of a different type was never seen. The watch handler (requeueClusterSummaryForReference) already calls clustercache.RemoveSecret correctly on every Secret event it sees. The fix consist in flipping the scoping from an allowlist to a denylist. Cache every Secret except Helm's own release-history storage (type == helm.sh/release.v1), Fixes projectsveltos#1954
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addon-controller never picks up a kubeconfig Secret's content changing until the pod itself restarts. This was reproduced: point a SveltosCluster's kubeconfig Secret at a new cluster's API server and delete the old cluster. Addon-controller keeps dialing the old, now-defunct IP indefinitely (dial tcp :6443: i/o timeout).
PR #1920 scoped the manager's Secret cache to type == addons.projectsveltos.io/cluster-profile (policyRef Secrets only), made unconditional. The ClusterSummaryReconciler's Secret watch is built on that same scoped informer, so a kubeconfig Secret update for a Secret of a different type was never seen. The watch handler (requeueClusterSummaryForReference) already calls clustercache.RemoveSecret correctly on every Secret event it sees.
The fix consist in flipping the scoping from an allowlist to a denylist. Cache every Secret except Helm's own release-history storage (type == helm.sh/release.v1),
Fixes #1954