Skip to content

fix: uninstall Helm charts in reverse of install order #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianlucam76 merged 1 commit into from
Sep 18, 2026
Merged

fix: uninstall Helm charts in reverse of install order #1984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions controllers/handlers_helm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,8 +970,12 @@ func uninstallHelmCharts(ctx context.Context, c client.Client, clusterSummary *c
}

releaseReports := make([]configv1beta1.ReleaseReport, 0)
for i := range clusterSummary.Spec.ClusterProfileSpec.HelmCharts {
currentChart := &clusterSummary.Spec.ClusterProfileSpec.HelmCharts[i]
// Uninstall in the reverse of install order (handled by walkChartsAndDeploy): a chart
// installed later in the list may depend on one installed earlier (e.g. a controller on a
// CRD chart), so tearing the whole profile down should undo that dependency last.
helmCharts := clusterSummary.Spec.ClusterProfileSpec.HelmCharts
for i := len(helmCharts) - 1; i >= 0; i-- {
currentChart := &helmCharts[i]

instantiatedChart, err := getInstantiatedChartIdentity(ctx, dCtx, currentChart, logger)
if err != nil {
Expand Down
Loading