fix: skip pull-mode clusters with a stale agent heartbeat - #507
Merged
Conversation
…ing deployment status classifier's only readiness gate before deploying/polling a cluster checks `SveltosCluster.Status.Ready`, which is set once at initial registration and never flips back to false when a pull-mode agent stops reporting. Only `Status.ConnectionStatus` moves to `Down`, which classifier never checks. As a result, a pull-mode cluster whose sveltos-applier agent has died still passes the readiness check on every reconcile, and classifier trying to deploy to such a cluster. This PR adds `isAgentHealthy`, matching the helper already present in addon-controller, event-manager, and healthcheck-manager: for a pull-mode `SveltosCluster`, it checks `pullmode.IsAgentTimeoutError(sveltosCluster)` (backed by the heartbeat-timeout `FailureMessage` set by sveltoscluster-manager).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
classifier's only readiness gate before deploying/polling a cluster checks
SveltosCluster.Status.Ready, which is set once at initial registration and never flips back to false when a pull-mode agent stops reporting. OnlyStatus.ConnectionStatusmoves toDown, which classifier never checks.As a result, a pull-mode cluster whose sveltos-applier agent has died still passes the readiness check on every reconcile, and classifier trying to deploy to such a cluster.
This PR adds
isAgentHealthy, matching the helper already present in addon-controller, event-manager, and healthcheck-manager: for a pull-modeSveltosCluster, it checkspullmode.IsAgentTimeoutError(sveltosCluster)(backed by the heartbeat-timeoutFailureMessageset by sveltoscluster-manager).