role secret labels and lookups ignored cluster type - #688
Open
magic-peach wants to merge 1 commit into
Open
magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
CreateSecret, GetSecret, DeleteSecret and GetKubeconfig in lib/roles all took a clusterType argument but never used it, so the Secret storing a RoleRequest kubeconfig was never labeled with its cluster type and lookups matched on cluster name and service account alone. A Cluster and a SveltosCluster sharing the same name and namespace could end up reading or deleting each other's secret. Add a role-cluster-type label, set it when the secret is created, and include it in the label selector used everywhere secrets are looked up. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateSecret, GetSecret, DeleteSecret and GetKubeconfig in lib/roles all take a clusterType argument but never used it, so the Secret storing a RoleRequest kubeconfig was never labeled with its cluster type and lookups matched on cluster name and service account alone. A Cluster and a SveltosCluster sharing the same name and namespace could end up reading or deleting each other's secret.
Adds a role-cluster-type label, sets it when the secret is created, and includes it in the label selector used everywhere secrets are looked up.
Tested with go build, go vet and go test ./lib/roles/..., all passing.