Prepare 0.34.1 - #5556
Open
Spaceman1701 wants to merge 3 commits into
Open
Conversation
Spaceman1701
force-pushed
the
prepare-0.34.1
branch
from
September 11, 2026 10:20
462f77f to
2291dc9
Compare
…s#5468) chore(deps): bump golang.org/x/mod to fix CVEs Signed-off-by: Mostafa-Yehia <mostafa.yehia.iti@gmail.com> Signed-off-by: Ethan Hunter <ehunter@hudson-trading.com>
This fix is based on HRT's inhibitor implementation. It updates the index so that each equal-labels key holds a `FingerprintSet` instead of a `Fingerprint` so that the index stores _every_ matching source alert instead of _one_ matching source alert. This allows the inhibitor to search through all the alerts in the index for the set of equal-labels to select the best candidate. Worst case, this does degrade inhibitor performance to `O(n)`, but in practice it should be similar to today (since the first element of the set is most likely a viable candidate). ```release-notes [BUGFIX] fix various issues with the inhibitor improperly skipping inhibits when the indexed source alert is resolved but other alerts are present. ``` --------- Signed-off-by: Ethan Hunter <ehunter@hudson-trading.com>
Signed-off-by: Ethan Hunter <ehunter@hudson-trading.com>
Spaceman1701
force-pushed
the
prepare-0.34.1
branch
from
September 11, 2026 10:23
2291dc9 to
4a5bca5
Compare
SoloJacobs
requested changes
Sep 12, 2026
|
|
||
| ## 0.34.1 / 2026-09-11 | ||
|
|
||
| * [BUGFIX] fix various issues with the inhibitor improperly skipping inhibits when the indexed source alert is resolved but other alerts are present. |
Contributor
There was a problem hiding this comment.
- We uppercase the start of these.
- link the PR number at the end.
- Optionally have the
inhibitcomponent at the start.
Could we also make it a bit more user-facing?
[BUGFIX] inhibit: Fix alerts not being muted when a source alert resolves while other matching source alerts are still firing. #5542
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare 0.34.1 with the inhibitor fixes from #5542 and dependency updates from #5468