Skip to content

Removing unused service-account secret from 1b_secret - #412

Merged
geekodour merged 1 commit into
prometheus:masterfrom
imrajdas:gke-test
Jul 30, 2020
Merged

geekodour merged 1 commit into
prometheus:masterfrom
imrajdas:gke-test

Conversation

@imrajdas

@imrajdas imrajdas commented Jul 18, 2020

Copy link
Copy Markdown
Contributor

Signed-off-by: Raj Babu Das mail.rajdas@gmail.com

@imrajdas

Copy link
Copy Markdown
Contributor Author

cc @geekodour

@geekodour

Copy link
Copy Markdown
Contributor

Could we also remove this?

AUTH_FILE = /etc/serviceaccount/service-account.json

@imrajdas

Copy link
Copy Markdown
Contributor Author

AUTH_FILE is used by other make steps in Makefile. If we remove this other commands will not work

@geekodour

Copy link
Copy Markdown
Contributor

We don't need the default value anymore, since we're providing it in our command runs.

It was used for this:

mountPath: /etc/serviceaccount/

It should work, can you check?

@imrajdas

Copy link
Copy Markdown
Contributor Author

We don't need the default value anymore, since we're providing it in our command runs.

It was used for this:

mountPath: /etc/serviceaccount/

It should work, can you check?

Okay, Will remove it.

@geekodour

Copy link
Copy Markdown
Contributor

could you remove this line from the readme aswell? :) as it's no longer used.

-v GKE_AUTH="$(cat $AUTH_FILE | base64 -w 0)" \

Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
@imrajdas

Copy link
Copy Markdown
Contributor Author

could you remove this line from the readme aswell? :) as it's no longer used.

-v GKE_AUTH="$(cat $AUTH_FILE | base64 -w 0)" \

Removed

@geekodour
geekodour merged commit e7f8c93 into prometheus:master Jul 30, 2020
@geekodour

Copy link
Copy Markdown
Contributor

@rajdas98 please get rid of this line aswell :)

Note: Use -v GKE_AUTH="$(echo $AUTH_FILE | base64 -w 0)" if you're passing the data directly into $AUTH_FILE

kushalShukla-web pushed a commit to kushalShukla-web/test-infra that referenced this pull request Feb 8, 2025
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants