feat(brief): add standing test-selection contract to ship and scout scaffolds - #13
Merged
Conversation
…caffolds Every spawned worker now verifies efficiently instead of defaulting to the full local suite: no full-suite first run, changed-first selection (fm-test-run.sh --changed here, the project runner's native equivalent elsewhere), failed-family-only reruns, GitHub CI as the PR merge verdict, and full output kept in a file so failures need no rerun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a standing Test selection contract section to the ship and scout brief scaffolds in
bin/fm-brief.sh, so every firstmate-spawned worker verifies efficiently instead of running the full local suite by default.The contract carries all four required points:
bin/fm-test-run.sh --changed(add--base <ref>when the working base is not origin/main); on other projects use the runner's native changed/related feature (e.g.vitest --changed).--family <name>or the single script), never the whole suite.tail(or any filter) that discards per-test result lines - keep full output in a file so failures are identifiable without rerunning.The section is built once as a shared variable and rendered into both scaffolds; secondmate charters do not carry it, matching the CodeGraph contract's scope. The script header documents the new standing contract.
Out of scope (per task)
No changes to
bin/fm-test-run.sh, CI workflows, or per-project runners.Verification
bin/fm-lint.sh: clean (pinned ShellCheck 0.11.0, actionlint 1.7.12).tests/fm-brief.test.sh: 22/22 ok, including newtest_test_selection_contract_in_ship_and_scout_briefsasserting all four points in both ship and scout briefs and their absence from secondmate charters.bin/fm-test-run.sh --changed --base origin/main: full changed selection (32 scripts) exit=0 failed=0, confirmed twice consecutively. One transient failure appeared on the very first pass and did not reproduce across two full reruns.