chore: update pull request - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Point intake at the planning skill family (task-grill, task-design, task-planning are all already on main). Minimal AGENTS.md + docs routing updates only. (1) AGENTS.md section 7: update the existing task-planning delegation sentence to the family flow - non-Simple ship intake goes task-grill first as the hard gate, then task-design when a design question exists, then task-planning spec/tickets ending in the terminal captain-review ticket; kept to 1-2 sentences. (2) AGENTS.md section 13: add two agent-only entries with one-line condition-style triggers - task-grill (load at non-Simple ship intake before any planning artifacts; owns the frontier interrogation and hard gate) and task-design (load when task-grill or the captain identifies a design question needing a prototype; owns Lavish prototype review). (3) docs/task-planning.md was already synced to family structure by an earlier task; touch it only where references still name the single-skill era incorrectly - two such touch-ups made: 'The planning skill composes' -> 'The planning family composes', and 'loads the skill only at that named trigger' -> 'loads each skill only at its named trigger'. Constraints accepted by the user: do NOT restate skill contracts in AGENTS.md (pointers/triggers only); do not touch other sections; diff must stay limited to AGENTS.md plus possibly docs/task-planning.md touch-ups. Acceptance: bin/fm-doc-audience-check.sh passes (verified green). Commit message fixed as docs(routing): point intake at the planning skill family.
What Changed
Final changed paths and statuses:
Risk Assessment
✅ Low: A minimal, docs-only routing update whose diff exactly matches the two named files and all specified edits, with wording verified consistent against the existing skill contracts on main.
Testing
Validated the docs-routing change end-to-end by running the specified acceptance script
bin/fm-doc-audience-check.sh(green, exit 0) on the target commit, verifying via git diff that the change is scoped to only AGENTS.md and docs/task-planning.md with exactly the described section 7 family-flow sentence, section 13 agent-only triggers, and the two named docs touch-ups, and confirming all three referenced skills exist on main with matching trigger semantics; evidence captured as command output artifact, overall result: pass.Evidence: fm-doc-audience-check.sh acceptance run (green)
Source: fm-doc-audience-check.sh acceptance run (green)
$ bash bin/fm-doc-audience-check.sh fm-doc-audience-check: ok surfaces=77 local_links=266 exit=0Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
git diff 67f678c..4ef7293 --stat— confirmed diff limited to AGENTS.md (+5/-1) and docs/task-planning.md (2 line touch-ups), satisfying the diff-scope constraintbash bin/fm-doc-audience-check.sh— passed green (exit 0,ok surfaces=77 local_links=266), the stated acceptance gateManual inspection of AGENTS.md lines 295-296 — section 7 delegation sentence now names the family flow (task-grill hard gate first, task-design conditionally, task-planning spec/tickets, terminal captain-review ticket) in exactly 2 sentencesManual inspection of AGENTS.md lines 540-541 — section 13 contains the new one-line condition-style agent-only entries fortask-grillandtask-designunder the existing not-captain-invocable listManual inspection of docs/task-planning.md diff hunks — only the two named single-skill-era phrasings were touchedls .agents/skills/+ SKILL.md frontmatter check — task-grill, task-design, and task-planning all exist on main and their descriptions match the routing conditions written into AGENTS.mdAGENTS.md:295- New §7 wording sequences intake as grill → design → planning, while task-grill/SKILL.md's front-matter description and the docs/task-planning.md artifact-flow diagram describe task-planning classifying the request and routing non-Simple work to task-grill at intake. Both satisfy the binding constraint (grill is the hard gate before any planning artifacts), so no edit was made; resolving who nominally classifies at intake may deserve a follow-up alignment in the skill owners.✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.