Convert MMIO accesses in assembly to C#837
Open
uyjulian wants to merge 1 commit intops2dev:masterfrom
Open
Conversation
rickgaiser
reviewed
May 8, 2026
| " lw %1, -0x6000(%0) \n" | ||
| " .set pop \n" | ||
| : "=&r"(dma_addr), "=&r"(status)); | ||
| while ((*((vu32 *)0x1000a000) & 0x100) != 0); // Wait until STR bit of D2_CHCR = 0 |
Member
There was a problem hiding this comment.
Very nice improvement to readability. But can you go 1 step further and also replace the magic numbers with their register definitions? Like R_EE_D2_CHCR in this case?
ps2sdk/common/include/ee_regs.h
Line 101 in 5a63561
ps2sdk/common/include/ee_regs.h
Line 384 in 5a63561
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For better readability
Tested working