Skip to content

test(ios): eliminate Swift concurrency warnings (#154) #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psimaker merged 1 commit into from
Aug 27, 2026
Merged

test(ios): eliminate Swift concurrency warnings (#154) #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ios/VaultSyncTests/RelaySetupDoctorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import Testing

@Suite("Relay setup --doctor escalation (#91)")
struct RelaySetupDoctorTests {
@Test("Doctor command targets the container the installer creates and invokes --doctor")
@Test("Doctor command targets the container the installer creates and invokes --doctor (#154)")
@MainActor
func doctorCommandShape() {
// The in-app command must keep matching the container name the one-line
// installer (and the docker run alternative on the same screen) uses.
Expand Down
8 changes: 4 additions & 4 deletions ios/VaultSyncTests/ShareAcceptCoordinatorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ struct ShareAcceptCoordinatorTests {
var accepts: [(id: String, mergeConfirmed: Bool)] = []
var unignored: [String] = []
var ignored: [String] = []
var settled = true
}

private static func env(
Expand Down Expand Up @@ -144,16 +145,15 @@ struct ShareAcceptCoordinatorTests {
#expect(!reached)
}

@Test("Merge confirmation re-runs the accept WITH consent and re-checks settlement at confirm time")
@Test("Merge confirmation re-runs the accept WITH consent and re-checks settlement at confirm time (#154)")
func confirmMergeRerunsWithConsentAndRevalidates() {
let recorder = Recorder()
var settled = true
let c = ShareAcceptCoordinator(environment: Self.env(
settled: { settled }, pending: [Self.offer("f1")], recorder: recorder))
settled: { recorder.settled }, pending: [Self.offer("f1")], recorder: recorder))
let request = ShareAcceptCoordinator.MergeConfirmationRequest(folder: Self.offer("f1"), targetName: "T")
c.confirmMergeAccept(request)
#expect(recorder.accepts.map { $0.mergeConfirmed } == [true])
settled = false
recorder.settled = false
c.confirmMergeAccept(request)
#expect(recorder.accepts.count == 1) // held; transient message instead
#expect(c.alertMessage == L10n.tr("Vault locations are still being checked. Try again in a moment."))
Expand Down
Loading