Skip to content

Correct typos in perez and perez_driesse docstrings#2770

Merged
kandersolar merged 1 commit into
pvlib:mainfrom
kandersolar:sec-cos
Jun 1, 2026
Merged

Correct typos in perez and perez_driesse docstrings#2770
kandersolar merged 1 commit into
pvlib:mainfrom
kandersolar:sec-cos

Conversation

@kandersolar
Copy link
Copy Markdown
Member

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • [ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

These docstrings mention a 1/sec(z) airmass model. Of course it should be 1/cos(z).

@kandersolar kandersolar added this to the v0.15.2 milestone Jun 1, 2026
Copy link
Copy Markdown
Member

@echedey-ls echedey-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I didn't find any other occurrences in the project

@kandersolar kandersolar merged commit a53e022 into pvlib:main Jun 1, 2026
33 checks passed
@kandersolar kandersolar deleted the sec-cos branch June 1, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants