test: reject shared_ptr casts for custom holders#6069
Merged
rwgk merged 2 commits intoMay 19, 2026
Conversation
Lock down the current behavior discussed in issue pybind#6064: py::cast() from std::shared_ptr<T> remains rejected for custom holder bindings that are not std::shared_ptr or py::smart_holder. This extracts the incompatible-holder coverage from PR pybind#6068 and adds a test shaped like issue pybind#6064, while PR pybind#6065 and PR pybind#6066 explore alternative support paths.
This was referenced May 18, 2026
virtuald
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #6064
Lock down the current behavior discussed in issue #6064:
py::cast()fromstd::shared_ptr<T>remains rejected for custom holder bindings that are notstd::shared_ptrorpy::smart_holder.This extracts the incompatible-holder coverage from PR #6068 and adds a test shaped like issue #6064.
See also: PR #6065, PR #6066
Suggested changelog entry: