reverting real coordinates - #163
Merged
Merged
Conversation
e-moral-sanchez
approved these changes
Jul 24, 2024
e-moral-sanchez
left a comment
e-moral-sanchez
left a comment
Contributor
There was a problem hiding this comment.
Ok. I will take a look at this later on. Thanks!
This was referenced Jul 24, 2024
Member
|
@campospinto @e-moral-sanchez What is the current status on this matter? Is there an open issue? |
Collaborator
Author
I don't think so, but it would be good indeed to have one that describes precisely the problem. Note that the previous PR #156 was breaking some calls to TerminalExpr of derivatives (returning zeros for non-constant functions), probably because the coordinate symbols were not properly identified. Some of the corresponding code is now tested in the (still open) PR #161, so that the problem can be detected at sympde level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #156 defined domain coordinates with real=True argument. This is probably justified but requires additional testing as it breaks some calls to TerminalExpr. Here this change is reverted, and a dedicated PR will be reopened later.